Skip to content

Conversation

@arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal requested a review from a team as a code owner August 26, 2025 07:01
@arjan-bal arjan-bal requested a review from sergiitk August 26, 2025 07:01
Copy link
Contributor

@pawbhard pawbhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjan-bal arjan-bal requested a review from sergiitk August 27, 2025 14:05
@arjan-bal arjan-bal force-pushed the fix-regional-cluster-cleanup branch from c1f3a3a to ad77fa8 Compare September 8, 2025 08:03
@sergiitk
Copy link
Member

sergiitk commented Sep 8, 2025

Oh, the test run is executed against your branch in grpc/grpc:

github_scm_revision 	 {
  commit_sha: "psm-inteorp/fix-regional-cluster-cleanup"
  name: "grpc"
  owner: "arjan-bal"
  repository: "grpc"
}

Please run against master:

github_scm_revision 	 {
  commit_sha: "master"
  name: "grpc"
  owner: "grpc"
  repository: "grpc"
}

@arjan-bal
Copy link
Contributor Author

Oh, the test run is executed against your branch in grpc/grpc:

github_scm_revision 	 {
  commit_sha: "psm-inteorp/fix-regional-cluster-cleanup"
  name: "grpc"
  owner: "arjan-bal"
  repository: "grpc"
}

Please run against master:

github_scm_revision 	 {
  commit_sha: "master"
  name: "grpc"
  owner: "grpc"
  repository: "grpc"
}

Here's the run with all the changes: https://source.cloud.google.com/results/invocations/1ff70c6b-2b91-4e9d-838a-dd6b8eb43c64

@arjan-bal arjan-bal requested a review from sergiitk September 8, 2025 09:11
@arjan-bal arjan-bal merged commit fd1ea31 into grpc:main Sep 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants